Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): deprecate `packageJson` option #2034

Merged
merged 1 commit into from Oct 18, 2020

Conversation

@ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Oct 17, 2020

Summary

This option is not used internally so we can deprecate it and remove it in v27

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner Oct 17, 2020
@coveralls
Copy link

@coveralls coveralls commented Oct 17, 2020

Pull Request Test Coverage Report for Build 6162

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 93.533%

Totals Coverage Status
Change from base Build 6160: -0.003%
Covered Lines: 1083
Relevant Lines: 1114

💛 - Coveralls
src/config/config-set.spec.ts Outdated Show resolved Hide resolved
src/config/config-set.spec.ts Outdated Show resolved Hide resolved
The option `packageJson` is not used in internal `ts-jest` so it makes sense to remove it.
@ahnpnl ahnpnl force-pushed the ahnpnl:refactor-config-3 branch from 2d74c63 to 494946f Oct 17, 2020
@ahnpnl ahnpnl merged commit 1538fa6 into kulshekhar:master Oct 18, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 93.533%
Details
@ahnpnl ahnpnl deleted the ahnpnl:refactor-config-3 branch Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.