Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): expose several typings as public apis #2054

Merged
merged 1 commit into from Oct 22, 2020

Conversation

@ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Oct 22, 2020

Summary

  • Expose several properties in ConfigSet

  • Expose JsonableValue and some json utils

  • Expose updateOutput function in compiler

TypeScript doesn't allow subclass to use parent class getters so we have to convert public getters to public properties, see microsoft/TypeScript#338

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner Oct 22, 2020
@coveralls
Copy link

@coveralls coveralls commented Oct 22, 2020

Pull Request Test Coverage Report for Build 6267

  • 22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 93.654%

Totals Coverage Status
Change from base Build 6266: -0.04%
Covered Lines: 1018
Relevant Lines: 1047

💛 - Coveralls
@ahnpnl ahnpnl merged commit 3b6b705 into kulshekhar:master Oct 22, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 93.654%
Details
@ahnpnl ahnpnl deleted the ahnpnl:typings branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.