Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(compiler): speed up bootstrap time for `isolatedModules:false` #2055

Merged
merged 3 commits into from Oct 23, 2020

Conversation

@ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Oct 22, 2020

Summary

  • Initializing LanguageService with fetching only .d.ts files. This will reduce the amount of TypeScript file system I/O at startup

  • Update e2e templates' dependencies as well.

Test plan

Added an extra project to measure memory heap usage

Green CI

Does this PR introduce a breaking change?

Hopefully won't

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner Oct 22, 2020
@coveralls
Copy link

@coveralls coveralls commented Oct 22, 2020

Pull Request Test Coverage Report for Build 6275

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.654%

Totals Coverage Status
Change from base Build 6274: 0.0%
Covered Lines: 1018
Relevant Lines: 1047

💛 - Coveralls
@ahnpnl ahnpnl marked this pull request as draft Oct 22, 2020
Initializing `LanguageService` with fetching only `.d.ts` files
@ahnpnl ahnpnl force-pushed the ahnpnl:performance branch from aec09d9 to daeb6d9 Oct 22, 2020
@ahnpnl ahnpnl changed the title perf(compiler): exclude test files from `LanguageService` initialization perf(compiler): speed up bootstrap time for `isolatedModules:true` Oct 22, 2020
@ahnpnl ahnpnl marked this pull request as ready for review Oct 22, 2020
@ahnpnl ahnpnl merged commit 230b5dd into kulshekhar:master Oct 23, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 93.654%
Details
@ahnpnl ahnpnl changed the title perf(compiler): speed up bootstrap time for `isolatedModules:true` perf(compiler): speed up bootstrap time for `isolatedModules:false` Oct 23, 2020
ahnpnl added a commit that referenced this pull request Oct 23, 2020
…true` (#2055)"

This reverts commit 230b5dd.
@ahnpnl ahnpnl deleted the ahnpnl:performance branch Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.