Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): allow to override `readTsConfig` #2063

Merged
merged 2 commits into from Oct 26, 2020
Merged

Conversation

@ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Oct 24, 2020

Summary

  • Allow to override readTsConfig
  • Expose _transformCfgStr, _configSet, _overriddenCompilerOptions

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner Oct 24, 2020
@coveralls
Copy link

@coveralls coveralls commented Oct 25, 2020

Pull Request Test Coverage Report for Build 6320

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.661%

Totals Coverage Status
Change from base Build 6319: 0.003%
Covered Lines: 1020
Relevant Lines: 1049

💛 - Coveralls
@ahnpnl ahnpnl force-pushed the ahnpnl:typings branch from 112990f to 92bdc8a Oct 25, 2020
@ahnpnl ahnpnl marked this pull request as draft Oct 25, 2020
@ahnpnl ahnpnl force-pushed the ahnpnl:typings branch from 92bdc8a to fc00820 Oct 25, 2020
@ahnpnl ahnpnl marked this pull request as ready for review Oct 25, 2020
- Change `_readTsConfig` to `_resolveTsConfig`
- Allow to override `_resolveTsConfig` via overload signature
- Expose `_transformCfgStr`, `_configSet`, `_overriddenCompilerOptions`
@ahnpnl ahnpnl force-pushed the ahnpnl:typings branch from fc00820 to 9a86ed3 Oct 26, 2020
@ahnpnl ahnpnl changed the title refactor(config): allow to override `readTsConfig` feat(config): allow to override `readTsConfig` Oct 26, 2020
@ahnpnl ahnpnl requested a review from kulshekhar Oct 26, 2020
@ahnpnl ahnpnl merged commit 9f46ace into kulshekhar:master Oct 26, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage increased (+0.003%) to 93.661%
Details
@ahnpnl ahnpnl deleted the ahnpnl:typings branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.