Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compiler): prevent side effects for compiler options #2279

Merged
merged 1 commit into from Jan 15, 2021
Merged

refactor(compiler): prevent side effects for compiler options #2279

merged 1 commit into from Jan 15, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jan 15, 2021

Summary

Create a copy of initial compiler options and reuse them later for processing.

Test plan

Adjusted unit tests, green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

Create a copy of initial compiler options and reuse them later for processing
@coveralls
Copy link

coveralls commented Jan 15, 2021

Pull Request Test Coverage Report for Build 487720375

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.654%

Totals Coverage Status
Change from base Build 487335805: 0.0%
Covered Lines: 948
Relevant Lines: 978

💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review January 15, 2021 11:02
@ahnpnl ahnpnl merged commit 275d6ac into kulshekhar:master Jan 15, 2021
@ahnpnl ahnpnl deleted the prevent-sideffect-compiler-options branch January 15, 2021 12:46
@ahnpnl ahnpnl added this to the ts-jest v27 milestone Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants