Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): return file content on emitSkipped for non ts/tsx files #2519

Merged
merged 1 commit into from Apr 14, 2021

Conversation

@ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 14, 2021

Summary

When encountering emitSkipped:

  • Return file content and show a warning message for non ts/tsx files.
  • Throw error for ts/tsx files

Closes #2513

Test plan

Added unit test
Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

@coveralls coveralls commented Apr 14, 2021

Pull Request Test Coverage Report for Build 748618194

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.951%

Totals Coverage Status
Change from base Build 747369490: 0.01%
Covered Lines: 1000
Relevant Lines: 1030

💛 - Coveralls

Loading

@ahnpnl ahnpnl marked this pull request as ready for review Apr 14, 2021
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner Apr 14, 2021
@ahnpnl ahnpnl merged commit a4e5640 into kulshekhar:master Apr 14, 2021
15 checks passed
Loading
@ahnpnl ahnpnl deleted the fix-emit-skip branch Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants