Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .ts extension for extensionsToTreatAsEsm option

Merged
merged 4 commits into from Jun 7, 2022

Conversation

bmaclean
Copy link
Contributor

@bmaclean bmaclean commented Jun 7, 2022

Summary

Test plan

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The suggested *.ts is an invalid value for the extensionsToTreatAsEsm Jest config option.

@bmaclean bmaclean requested a review from kulshekhar as a code owner Jun 7, 2022
@ahnpnl
Copy link
Collaborator

ahnpnl commented Jun 7, 2022

Would you please also adjust for all esm-support.md files existing in website/version_docs? Potentially those files are under all folders in website/version_docs excluding website/version_docs/version-26.5.

@coveralls
Copy link

coveralls commented Jun 7, 2022

Pull Request Test Coverage Report for Build 2456865727

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.792%

Totals Coverage Status
Change from base Build 2452682109: 0.0%
Covered Lines: 1120
Relevant Lines: 1147

💛 - Coveralls

ahnpnl
ahnpnl approved these changes Jun 7, 2022
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Thanks!

@ahnpnl ahnpnl merged commit 770abea into kulshekhar:main Jun 7, 2022
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants