Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable contextcheck #3412

Merged
merged 2 commits into from Dec 2, 2021

Conversation

michaelbeaumont
Copy link
Contributor

Summary

This at least checks we don't make the mistake of missing an existing
context.

This at least checks we don't make the mistake of missing an existing
context.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner December 1, 2021 23:44
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3412 (12b20b2) into master (ff7a55f) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3412      +/-   ##
==========================================
- Coverage   52.15%   52.14%   -0.02%     
==========================================
  Files         938      938              
  Lines       54587    54587              
==========================================
- Hits        28470    28464       -6     
- Misses      23886    23892       +6     
  Partials     2231     2231              
Impacted Files Coverage Δ
pkg/core/config/manager/manager.go 50.00% <0.00%> (ø)
pkg/core/secrets/manager/global_manager.go 39.39% <0.00%> (ø)
pkg/core/secrets/manager/manager.go 36.98% <0.00%> (ø)
pkg/plugins/bootstrap/k8s/plugin.go 1.28% <0.00%> (ø)
.../plugins/runtime/k8s/controllers/pod_controller.go 41.79% <0.00%> (ø)
...gins/runtime/k8s/controllers/outbound_converter.go 67.16% <66.66%> (ø)
...g/plugins/runtime/k8s/controllers/pod_converter.go 64.00% <75.00%> (ø)
...ugins/runtime/k8s/controllers/ingress_converter.go 70.66% <83.33%> (ø)
pkg/hds/authn/callbacks.go 69.62% <100.00%> (ø)
pkg/plugins/secrets/k8s/store.go 75.30% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7a55f...12b20b2. Read the comment docs.

Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbeaumont michaelbeaumont merged commit af1399a into kumahq:master Dec 2, 2021
@michaelbeaumont michaelbeaumont deleted the ci/contextcheck branch August 30, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants