Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): correct bad retry on apply #3681

Merged
merged 2 commits into from Jan 10, 2022
Merged

Conversation

lahabana
Copy link
Contributor

Summary

we switched around the message and the regex so the retry wasn't working

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • [ ] Update UPGRADE.md with any steps users will need to take when upgrading.
  • [ ] Add backport-to-stable label if the code follows our backporting policy

we switched around the message and the regex so the retry wasn't working

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner January 10, 2022 11:33
@codecov-commenter
Copy link

Codecov Report

Merging #3681 (15cc1d2) into master (62ea035) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3681      +/-   ##
==========================================
+ Coverage   50.91%   50.92%   +0.01%     
==========================================
  Files         930      930              
  Lines       56488    56488              
==========================================
+ Hits        28760    28767       +7     
+ Misses      25449    25435      -14     
- Partials     2279     2286       +7     
Impacted Files Coverage Δ
test/framework/k8s_controlplane.go 0.00% <0.00%> (ø)
pkg/plugins/leader/postgres/leader_elector.go 93.61% <0.00%> (-6.39%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 61.53% <0.00%> (-5.13%) ⬇️
pkg/dns/vips_allocator.go 72.34% <0.00%> (-1.42%) ⬇️
pkg/core/resources/model/rest/resource.go 69.23% <0.00%> (+1.28%) ⬆️
pkg/insights/resyncer.go 73.61% <0.00%> (+2.45%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
pkg/insights/components.go 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ea035...15cc1d2. Read the comment docs.

@lahabana
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 10, 2022

update

✅ Branch has been successfully updated

@lahabana lahabana merged commit 754f592 into kumahq:master Jan 10, 2022
@lahabana lahabana deleted the retryMeshConflict branch March 29, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants