Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Init sub-projects, so their plugins are applied #8

Merged
merged 1 commit into from Sep 28, 2012

Conversation

Projects
None yet
3 participants
Contributor

hugoduncan commented Sep 27, 2012

Their could be a potential problem with this if the plugins provide hooks, as the hooks will not be cleared between sub-projects.

@technomancy - this is what I would like to have scoped hooks to support. Hence technomancy/robert-hooke#10

@kumarshantanu kumarshantanu added a commit that referenced this pull request Sep 28, 2012

@kumarshantanu kumarshantanu Merge pull request #8 from hugoduncan/init-sub-project
Init sub-projects, so their plugins are applied
b460574

@kumarshantanu kumarshantanu merged commit b460574 into kumarshantanu:master Sep 28, 2012

This change is leading to the message No value supplied for key: [:add-classpath? true] when trying to run lein-sub on sub-projects with no plugin hooks. Would you know the fix for it?

Owner

kumarshantanu commented Sep 29, 2012

Addressing @hugoduncan just in case you missed the notification. :)

Contributor

hugoduncan commented Sep 29, 2012

I can't reproduce the issue. I have seen that error message before though, but can't remember what the context was. Which version of lein are you testing with?

Owner

kumarshantanu commented Sep 30, 2012

I am running Leiningen 2.0.0-preview10 on Java 1.7.0_07 Java HotSpot(TM) Client VM on 32-bit Linux.

Contributor

hugoduncan commented Sep 30, 2012

I'm afraid I still can't provoke the error. Is this on a publicly available project? Does lein work correctly when invoked directly in the sub-project?

Maybe you could gist the exception. Looking at the leiningen code, l.c.classpath/resolve-dependencies is called with :add-classpath? true from l.c.project/load-plugins, and calls l.c.lasspath/get-dependencies passing the :add-classpath in it's rest argument. Nothing jumps out as being wrong there.

Owner

kumarshantanu commented Sep 30, 2012

I have added the subtest project that I was using to test lein-sub to this repo master. Individual lein clean, lein jar etc work fine on the child projects, but lein sub clean from within subtest produces the error I mentioned earlier.

Contributor

hugoduncan commented Sep 30, 2012

I'm afraid I can't reproduce this on my machine (OS X 10.7.4).

I did lein do clean, install in a clean checkout of master, and lein sub clean works from within subtest with lein preview 7 through preview 10, and with master. I've commented out the whole of my ~/.lein/profiles.clj while testing.

I have also tested on a clean Ubuntu 12.04 vm, with the same result.

Owner

kumarshantanu commented Sep 30, 2012

@hugoduncan Sorry to waste your time, the issue was with lein-pedantic 0.0.3 https://github.com/xeqi/lein-pedantic in my profiles.clj file. Maybe @xeqi would know what's up. I have pushed a 0.2.3 release to Clojars and updated the README.

Contributor

hugoduncan commented Sep 30, 2012

Glad to hear you found a cause. Thanks for the release!

@xeqi xeqi referenced this pull request in xeqi/lein-pedantic Sep 30, 2012

Closed

No value supplied for key: [:add-classpath? true] with lein-sub #8

xeqi commented Sep 30, 2012

Hmm, lein-pedantic does hooke that area to check dependencies. Made an issue to track/explore it in lein-pedantic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment