Windows compilation fails without #define NOMINMAX #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpatters1
added a commit
to finale-lua/LuaBridge3
that referenced
this pull request
Apr 3, 2023
…-no-enable-shared * dev/fix_class_hashing: Fix class hashing Update amalgamation file Fix invalid noexcept specification (kunitoki#100) Rename sonar.yml to sonar.yml_ Update amalgamation file enclose all calls to std::...min/max in parents (kunitoki#98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LuaBridge fails to compile on Windows Visual Studio 2023 unless
NOMINMAXis defined.The Windows sdk has really stupid macro definitions for
minandmax. You can suppress them withNOMINMAX, but imo it is incumbent on libraries where possible to accommodate this, since the fix is so easy.With
std::min(max)you simply enclose it in parentheses. That is:int x = std::min(a, b);becomes
int x = (std::min)(a, b);This PR applies similar parentheses to the calls in LuaHelper.h