Skip to content

Windows compilation fails without #define NOMINMAX #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Windows compilation fails without #define NOMINMAX #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions Source/LuaBridge/detail/LuaHelpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,23 +551,23 @@ constexpr bool is_integral_representable_by(T value)
return true;

if constexpr (std::is_unsigned_v<T>)
return value <= static_cast<T>(std::numeric_limits<U>::max());
return value <= static_cast<T>((std::numeric_limits<U>::max)());

return value >= static_cast<T>(std::numeric_limits<U>::min())
&& static_cast<U>(value) <= std::numeric_limits<U>::max();
return value >= static_cast<T>((std::numeric_limits<U>::min)())
&& static_cast<U>(value) <= (std::numeric_limits<U>::max)();
}

if constexpr (sizeof(T) < sizeof(U))
{
return static_cast<U>(value) >= std::numeric_limits<U>::min()
&& static_cast<U>(value) <= std::numeric_limits<U>::max();
return static_cast<U>(value) >= (std::numeric_limits<U>::min)()
&& static_cast<U>(value) <= (std::numeric_limits<U>::max)();
}

if constexpr (std::is_unsigned_v<T>)
return value <= static_cast<T>(std::numeric_limits<U>::max());
return value <= static_cast<T>((std::numeric_limits<U>::max)());

return value >= static_cast<T>(std::numeric_limits<U>::min())
&& value <= static_cast<T>(std::numeric_limits<U>::max());
return value >= static_cast<T>((std::numeric_limits<U>::min)())
&& value <= static_cast<T>((std::numeric_limits<U>::max)());
}

template <class U = lua_Integer>
Expand All @@ -590,11 +590,11 @@ constexpr bool is_floating_point_representable_by(T value)
return true;

if constexpr (sizeof(T) < sizeof(U))
return static_cast<U>(value) >= -std::numeric_limits<U>::max()
&& static_cast<U>(value) <= std::numeric_limits<U>::max();
return static_cast<U>(value) >= -(std::numeric_limits<U>::max)()
&& static_cast<U>(value) <= (std::numeric_limits<U>::max)();

return value >= static_cast<T>(-std::numeric_limits<U>::max())
&& value <= static_cast<T>(std::numeric_limits<U>::max());
return value >= static_cast<T>(-(std::numeric_limits<U>::max)())
&& value <= static_cast<T>((std::numeric_limits<U>::max)());
}

template <class U = lua_Number>
Expand Down