Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make eio_custom return and type depend on node version. #26

Closed
wants to merge 15 commits into
from

Conversation

Projects
None yet
3 participants

toots commented Dec 16, 2011

This should allow the code to be built on node 0.4.x and node 0.6.x seamlessly.

kuno commented on 7be14f9 Jan 20, 2012

sorry make you wating for so long time, (so far, busying on company's project)
thanks for you code
Will it cause some troubles by including libgeoip source code?
I am not a expert on license, but I really worry about that.

Owner

toots replied Jan 20, 2012

Hi!

The source code is actually not included in the patch but downloaded at configure/build time. Thus, licensing concerns are only restricted to linking against the library, which is already the case without my patch and shouldn't be a problem anyway..

Owner

toots replied Jan 21, 2012

Hey,

Sorry, I don't know what was wrong with me, the source code is included...

License for libgeoip is LGPL, which means that, among others, you are free to distribute it, so there should be no problem bundling it with your source code.

kuno replied Jan 24, 2012

I think it's better downloading the souce code only when we need it.

what's the waf commands to build libgeoip from source code?

Owner

toots replied Jan 25, 2012

Downloading isn't my favorite option because URLs change, servers have downtimes and installer may not have access to internet..

In the current patch, bundled libgeoip is built by default. In order to build against a shared one, one has to do:

node-waf --shared-geoip configure

Additionally, location for the library can be specified by using the --geoip option.

@kuno kuno closed this Mar 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment