From 20214d753e15aefee645bfaf44a72b91c60c0e90 Mon Sep 17 00:00:00 2001 From: Oleksandr Avoiants Date: Wed, 6 Apr 2016 20:09:13 +0300 Subject: [PATCH] Use String interpolation or << instead plus which are faster --- lib/rack/auth/digest/params.rb | 3 +-- lib/rack/common_logger.rb | 2 +- lib/rack/directory.rb | 2 +- lib/rack/multipart/generator.rb | 2 +- lib/rack/multipart/parser.rb | 2 +- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/rack/auth/digest/params.rb b/lib/rack/auth/digest/params.rb index f35a7bab8..90ad873f5 100644 --- a/lib/rack/auth/digest/params.rb +++ b/lib/rack/auth/digest/params.rb @@ -38,7 +38,7 @@ def []=(k, v) def to_s map do |k, v| - "#{k}=" + (UNQUOTED.include?(k) ? v.to_s : quote(v)) + "#{k}=" << (UNQUOTED.include?(k) ? v.to_s : quote(v)) end.join(', ') end @@ -50,4 +50,3 @@ def quote(str) # From WEBrick::HTTPUtils end end end - diff --git a/lib/rack/common_logger.rb b/lib/rack/common_logger.rb index 1ec8266d6..ae410430e 100644 --- a/lib/rack/common_logger.rb +++ b/lib/rack/common_logger.rb @@ -48,7 +48,7 @@ def log(env, status, header, began_at) now.strftime("%d/%b/%Y:%H:%M:%S %z"), env[REQUEST_METHOD], env[PATH_INFO], - env[QUERY_STRING].empty? ? "" : "?"+env[QUERY_STRING], + env[QUERY_STRING].empty? ? "" : "?#{env[QUERY_STRING]}", env[HTTP_VERSION], status.to_s[0..3], length, diff --git a/lib/rack/directory.rb b/lib/rack/directory.rb index 554f9c337..5baee3c89 100644 --- a/lib/rack/directory.rb +++ b/lib/rack/directory.rb @@ -155,7 +155,7 @@ def filesize_format(int) return format % (int.to_f / size) if int >= size end - int.to_s + 'B' + "#{int}B" end end end diff --git a/lib/rack/multipart/generator.rb b/lib/rack/multipart/generator.rb index 6367135f4..f0b70a8d6 100644 --- a/lib/rack/multipart/generator.rb +++ b/lib/rack/multipart/generator.rb @@ -22,7 +22,7 @@ def dump else content_for_other(file, name) end - end.join + "--#{MULTIPART_BOUNDARY}--\r" + end.join << "--#{MULTIPART_BOUNDARY}--\r" end private diff --git a/lib/rack/multipart/parser.rb b/lib/rack/multipart/parser.rb index 567c868d8..74a7ee67f 100644 --- a/lib/rack/multipart/parser.rb +++ b/lib/rack/multipart/parser.rb @@ -26,7 +26,7 @@ def read(size) str = if left < size @io.read left else - @io.read size + @io.read size end if str