Skip to content

Conversation

@w1am
Copy link
Contributor

@w1am w1am commented Nov 27, 2025

User description

  • Remove the vendored file and reference the official googleapis proto package

PR Type

Enhancement


Description

  • Remove vendored Google RPC proto files from repository

  • Replace local proto imports with official googleapis package

  • Update proto imports in streams and rpc files

  • Add blank lines to multiple Java and configuration files


Diagram Walkthrough

flowchart LR
  A["Vendored Proto Files<br/>code.proto, status.proto"] -->|Remove| B["Official googleapis<br/>Package"]
  C["Local Proto Imports<br/>kurrentdb/protocol/v1"] -->|Replace with| D["google/rpc Imports"]
  D --> E["streams.proto<br/>rpc.proto Updated"]
Loading

File Walkthrough

Relevant files
Dependencies
code.proto
Remove vendored Google RPC code proto file                             

src/main/proto/kurrentdb/protocol/v1/code.proto

  • Deleted entire vendored Google RPC code enum definition file
  • File contained 186 lines of gRPC canonical error codes
  • Removes duplicate of official googleapis proto
+0/-186 
status.proto
Remove vendored Google RPC status proto file                         

src/main/proto/kurrentdb/protocol/v1/status.proto

  • Deleted entire vendored Google RPC status message definition file
  • File contained 49 lines defining Status message type
  • Removes duplicate of official googleapis proto
+0/-49   
streams.proto
Update status proto import to googleapis                                 

src/main/proto/kurrentdb/protocol/v1/streams.proto

  • Updated import statement from local kurrentdb/protocol/v1/status.proto
    to google/rpc/status.proto
  • References official googleapis package instead of vendored file
+1/-1     
rpc.proto
Update code proto import to googleapis                                     

src/main/proto/kurrentdb/protocol/v2/rpc.proto

  • Updated import statement from local kurrentdb/protocol/v1/code.proto
    to google/rpc/code.proto
  • References official googleapis package instead of vendored file
+1/-1     
Formatting
AbortProjection.java
Add blank line formatting                                                               

src/main/java/io/kurrent/dbclient/AbortProjection.java

  • Added blank line at beginning of file
  • Formatting change only
+1/-0     
README.md
Add blank line formatting                                                               

README.md

  • Added blank line at beginning of file
  • Formatting change only
+1/-0     

@w1am w1am force-pushed the w1am/use-common-proto branch from 6ab46eb to 98881f9 Compare November 27, 2025 16:34
@w1am w1am changed the title Remove common proto files Remove the vendored file and reference the official googleapis proto package Nov 27, 2025
@w1am w1am marked this pull request as ready for review November 27, 2025 16:51
@qodo-code-review
Copy link

qodo-code-review bot commented Nov 27, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No audit impact: The changes only adjust proto imports and formatting without introducing or modifying any
action logic that would require audit logging.

Referred Code
import "google/rpc/status.proto";
import "google/protobuf/duration.proto";

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
Import change only: Switching proto imports to google/rpc does not add or alter any runtime error handling
paths in this diff, so robustness cannot be assessed here.

Referred Code
import "google/rpc/code.proto";

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status:
Error schema refs: The proto import change to google/rpc/code.proto affects error typing only and does not
reveal user-facing error content in this diff.

Referred Code
import "google/rpc/code.proto";

Learn more about managing compliance generic rules or creating your own custom rules

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

qodo-code-review bot commented Nov 27, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Align protobuf package with project conventions

In streams.proto, change the protobuf package name from
event_store.client.streams to kurrentdb.protocol.v1.streams to align with the
project's directory structure and naming conventions.

src/main/proto/kurrentdb/protocol/v1/streams.proto [2]

-package event_store.client.streams;
+package kurrentdb.protocol.v1.streams;

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies an inconsistent protobuf package name that seems to be a copy-paste remnant, and proposes a fix that aligns it with the project's structure, improving code consistency.

Low
  • Update

@w1am w1am force-pushed the w1am/use-common-proto branch from f1b44bb to c89aa86 Compare November 27, 2025 16:56
@w1am w1am merged commit cd52d6b into trunk Nov 27, 2025
38 of 42 checks passed
@w1am w1am deleted the w1am/use-common-proto branch November 27, 2025 17:01
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w1am 👉 Created pull request targeting release/v1.1: #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants