Skip to content

Commit

Permalink
fix: rename --full-uuid to --full-uuids (#941)
Browse files Browse the repository at this point in the history
  • Loading branch information
h4ck3rk3y committed Jan 25, 2023
1 parent 61ee1e0 commit 7578296
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
10 changes: 5 additions & 5 deletions cli/cli/commands/enclave/inspect/inspect.go
Expand Up @@ -40,7 +40,7 @@ const (
apiContainerHostGrpcPortTitle = "API Container Host GRPC Port"
apiContainerHostGrpcProxyPortTitle = "API Container Host GRPC Proxy Port"

fullUuidFlagKey = "full-uuid"
fullUuidsFlagKey = "full-uuids"
fullUuidFlagKeyDefault = "false"

headerWidthChars = 100
Expand All @@ -62,8 +62,8 @@ var EnclaveInspectCmd = &engine_consuming_kurtosis_command.EngineConsumingKurtos
EngineClientContextKey: engineClientCtxKey,
Flags: []*flags.FlagConfig{
{
Key: fullUuidFlagKey,
Usage: "If true then Kurtosis prints full uuids instead of shortened uuids. Default false.",
Key: fullUuidsFlagKey,
Usage: "If true then Kurtosis prints full UUIDs instead of shortened UUIDs. Default false.",
Type: flags.FlagType_Bool,
Default: fullUuidFlagKeyDefault,
},
Expand Down Expand Up @@ -91,9 +91,9 @@ func run(
return stacktrace.Propagate(err, "Expected a value for non-greedy enclave identifier arg '%v' but none was found; this is a bug with Kurtosis!", enclaveIdentifierArgKey)
}

showFullUuids, err := flags.GetBool(fullUuidFlagKey)
showFullUuids, err := flags.GetBool(fullUuidsFlagKey)
if err != nil {
return stacktrace.Propagate(err, "Expected a value for the '%v' flag but failed to get it", fullUuidFlagKey)
return stacktrace.Propagate(err, "Expected a value for the '%v' flag but failed to get it", fullUuidsFlagKey)
}

kurtosisCtx, err := kurtosis_context.NewKurtosisContextFromLocalEngine()
Expand Down
10 changes: 5 additions & 5 deletions cli/cli/commands/enclave/ls/ls.go
Expand Up @@ -31,7 +31,7 @@ const (
kurtosisBackendCtxKey = "kurtosis-backend"
engineClientCtxKey = "engine-client"

fullUuidFlagKey = "full-uuid"
fullUuidsFlagKey = "full-uuids"
fullUuidFlagKeyDefault = "false"

emptyTimeForOldEnclaves = ""
Expand All @@ -45,8 +45,8 @@ var EnclaveLsCmd = &engine_consuming_kurtosis_command.EngineConsumingKurtosisCom
EngineClientContextKey: engineClientCtxKey,
Flags: []*flags.FlagConfig{
{
Key: fullUuidFlagKey,
Usage: "If true then Kurtosis prints full uuids instead of shortened uuids. Default false.",
Key: fullUuidsFlagKey,
Usage: "If true then Kurtosis prints full UUIDs instead of shortened UUIDs. Default false.",
Type: flags.FlagType_Bool,
Default: fullUuidFlagKeyDefault,
},
Expand All @@ -72,9 +72,9 @@ func run(
return stacktrace.Propagate(err, "An error occurred getting enclaves")
}

showFullUuids, err := flags.GetBool(fullUuidFlagKey)
showFullUuids, err := flags.GetBool(fullUuidsFlagKey)
if err != nil {
return stacktrace.Propagate(err, "Expected a value for the '%v' flag but failed to get it", fullUuidFlagKey)
return stacktrace.Propagate(err, "Expected a value for the '%v' flag but failed to get it", fullUuidsFlagKey)
}

tablePrinter := output_printers.NewTablePrinter(enclaveUuidColumnHeader, enclaveNameColumnHeader, enclaveStatusColumnHeader, enclaveCreationTimeColumnHeader)
Expand Down
4 changes: 2 additions & 2 deletions docs/docs/reference/resource-identifier.md
Expand Up @@ -28,7 +28,7 @@ UUID Name Ports Status
```

Notice how Kurtosis shows the shortened UUID by default. All CLI commands show
shortened UUIDs by default; if you want to see full UUIDs you can use the `--full-UUIDs` flag with the command. Rerunning the above command with `--full-UUID` you'd get
shortened UUIDs by default; if you want to see full UUIDs you can use the `--full-uuids` flag with the command. Rerunning the above command with `--full-uuids` you'd get

```
UUID: edfdbf5766f64a649efca11f51ebb4c1
Expand All @@ -50,7 +50,7 @@ Usage:
kurtosis enclave inspect [flags] enclave-identifier
Flags:
--full-UUID If true then Kurtosis prints full UUIDs instead of shortened UUIDs. Default false.
--full-uuids If true then Kurtosis prints full UUIDs instead of shortened UUIDs. Default false.
-h, --help help for inspect
Global Flags:
Expand Down

0 comments on commit 7578296

Please sign in to comment.