From 8b0fa623a2c73ec195e2204da5a8463e016e6833 Mon Sep 17 00:00:00 2001 From: Gyanendra Mishra Date: Mon, 24 Jul 2023 15:56:33 +0100 Subject: [PATCH] fix: no magic string replacement in python packages (#966) ## Description: Packages had magic string replacement now they don't --- .../kurtosis_instruction/tasks/run_python.go | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/core/server/api_container/server/startosis_engine/kurtosis_instruction/tasks/run_python.go b/core/server/api_container/server/startosis_engine/kurtosis_instruction/tasks/run_python.go index 0e84fbb340..418aa439c5 100644 --- a/core/server/api_container/server/startosis_engine/kurtosis_instruction/tasks/run_python.go +++ b/core/server/api_container/server/startosis_engine/kurtosis_instruction/tasks/run_python.go @@ -334,20 +334,11 @@ func (builtin *RunPythonCapabilities) TryResolveWith(instructionsAreEqual bool, } func setupRequiredPackages(ctx context.Context, builtin *RunPythonCapabilities) (*exec_result.ExecResult, error) { - var maybePackagesWithRuntimeValuesReplaced []string - for _, pythonPackage := range builtin.packages { - maybePackageWithRuntimeValueReplaced, err := magic_string_helper.ReplaceRuntimeValueInString(pythonPackage, builtin.runtimeValueStore) - if err != nil { - return nil, stacktrace.Propagate(err, "an error occurred while replacing runtime value in a package passed to run_python") - } - maybePackagesWithRuntimeValuesReplaced = append(maybePackagesWithRuntimeValuesReplaced, maybePackageWithRuntimeValueReplaced) - } - - if len(maybePackagesWithRuntimeValuesReplaced) == 0 { + if len(builtin.packages) == 0 { return nil, nil } - packageInstallationSubCommand := fmt.Sprintf("%v %v", pipInstallCmd, strings.Join(maybePackagesWithRuntimeValuesReplaced, spaceDelimiter)) + packageInstallationSubCommand := fmt.Sprintf("%v %v", pipInstallCmd, strings.Join(builtin.packages, spaceDelimiter)) packageInstallationCommand := []string{shellWrapperCommand, "-c", packageInstallationSubCommand} executionResult, err := builtin.serviceNetwork.RunExec(