Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a welcome message that will link the user to the rules on the website #9 #10

Conversation

@BosEriko
Copy link
Member

BosEriko commented Mar 15, 2020

Story Title

Create a welcome message that will link the user to the rules on the website #9

Changes made

  • add admin rights for prune and add welcome message for joining users
  • update current point
  • remove the prune message itself on the count
  • add a catch for prune
  • finish prune option
  • add prune option
  • add multiple printing
  • add a way to get avatar
  • update current point
  • add a way to check if someone is tagged on kick or not
  • add kick mention
  • provide a way to avoid multiple spaces
  • update prefix
  • add args-info
  • add current point
  • minimize the code by using args and command
  • fix warnings for closing curly brace and add user-info
  • add total members count
  • use starts with instead
  • remove config.json
  • add prefix
  • use ts-node-dev in favor of nodemon
  • add nodemon
  • destructure config.json
  • create config json and require it to index.ts
  • add a prefix config.json
  • add ping/pong feature
  • update tabbing to spaces instead of tab
  • update linter rules
  • add eslintrc
  • add guide to index.ts
  • remove tslint flag on index.ts
  • install eslint

How does the solution address the problem

This PR will add a welcome message for new users and a bunch of new commands

@BosEriko BosEriko self-assigned this Mar 15, 2020
@BosEriko BosEriko added this to In progress in Discord Bot via automation Mar 15, 2020
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 15, 2020

Score: 0.71

Best reviewed: commit by commit


Optimal code review plan (7 warnings, 4 commits squashed)

     install eslint

     remove tslint flag on index.ts

     add guide to index.ts

     add eslintrc

     update linter rules

     update tabbing to spaces instead of tab

add ping/pong feature

src/index.ts 60% changes removed in add prefix

     add a prefix config.json

create config json and require it to index.ts

src/index.ts 50% changes removed in destructure config.j...

     destructure config.json

add nodemon ... use ts-node-dev in f...

Squashed 2 commits:

add prefix

src/index.ts 60% changes removed in use starts with inst...

     remove config.json

use starts with instead

src/index.ts 67% changes removed in minimize the code by...

add total members count

src/index.ts 50% changes removed in fix warnings for clo...

fix warnings for closing curly brace and add user-info

src/index.ts 43% changes removed in minimize the code by...

     minimize the code by using args and command

     add current point

     add args-info

     update prefix

     provide a way to avoid multiple spaces

add kick mention ... add a way to check i...

Squashed 2 commits:

     update current point

     add a way to get avatar

     add multiple printing

     add prune option

finish prune option

src/index.ts 60% changes removed in remove the prune mes...

     add a catch for prune

     remove the prune message itself on the count

     update current point

     add admin rights for prune and add welcome message for joining users

Powered by Pull Assistant. Last update 8705ac8 ... 7528981. Read the comment docs.

@BosEriko BosEriko requested review from ajsabandal and NeonNature Mar 15, 2020
Copy link

Dante-Black left a comment

all good :3

@BosEriko

This comment has been minimized.

Copy link
Member Author

BosEriko commented Mar 15, 2020

@Dante-Black please comment 'LGTM' next. haha. don't ask me why, that's just how it is on PRs. lmao. I've been to 2 companies that does the same, even in big repos I've seen that comment.

@Dante-Black

This comment has been minimized.

Copy link

Dante-Black commented Mar 15, 2020

LGTM

@yashraikar1087

This comment has been minimized.

Copy link

yashraikar1087 commented Mar 15, 2020

Code looks fine, not really well versed with the discord library, what will I need to do to get this running locally ?

@BosEriko

This comment has been minimized.

Copy link
Member Author

BosEriko commented Mar 15, 2020

Code looks fine, not really well versed with the discord library, what will I need to do to get this running locally ?

You need to create your own discord bot and rename sample.env to .env. then edit xxxx and add your bot token instead.

after doing that just run

yarn install
yarn watch
@BosEriko

This comment has been minimized.

Copy link
Member Author

BosEriko commented Mar 15, 2020

Code looks fine, not really well versed with the discord library, what will I need to do to get this running locally ?

Be sure to invite the bot on your own discord server, though.

@BosEriko BosEriko closed this Mar 15, 2020
Discord Bot automation moved this from In progress to Done Mar 15, 2020
@BosEriko BosEriko reopened this Mar 15, 2020
Discord Bot automation moved this from Done to In progress Mar 15, 2020
Copy link

yashraikar1087 left a comment

LGTM

@BosEriko BosEriko requested review from ajsabandal and NeonNature and removed request for NeonNature and ajsabandal Mar 15, 2020
@NeonNature

This comment has been minimized.

Copy link
Contributor

NeonNature commented Mar 15, 2020

One question. I'm not familiar with the discord package yet, but is adminID confidential? Would it make a big difference to store it in .env or would that even matter?

@BosEriko

This comment has been minimized.

Copy link
Member Author

BosEriko commented Mar 15, 2020

@NeonNature it's my user ID. and I'm the admin. it's an ID and not a token. so no worries. For now I'm hardcoding it but I'll make it so that users can set the admins on their own servers.

Since we're just using this bot on our own server, for now, hard coding is fine.

@BosEriko

This comment has been minimized.

Copy link
Member Author

BosEriko commented Mar 15, 2020

if you check where adminID is being used, it's on message.author.id === adminID

Copy link
Contributor

NeonNature left a comment

LGTM. I see no potential issue with adminID then.

Copy link

ajsabandal left a comment

LGTM!

@BosEriko BosEriko merged commit 220a535 into kuru-project:master Mar 15, 2020
Discord Bot automation moved this from In progress to Done Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Discord Bot
  
Done
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.