Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide index.ts into commands #12 #13

Merged

Conversation

@BosEriko
Copy link
Member

BosEriko commented Mar 19, 2020

Story Title

Divide index.ts into commands

Changes made

  • move ping, server, and args-info to its own component
  • move avatar, kick and user-info to their own components
  • modularize the files
  • remove unwanted codes
  • remove the if-else chain
  • update checkpoint
  • remove .ts from file names
  • fix comments and add rules link on the welcome message

How does the solution address the problem

This PR will divide the commands into separate files

@BosEriko BosEriko added this to the MVP milestone Mar 19, 2020
@BosEriko BosEriko requested a review from NeonNature Mar 19, 2020
@BosEriko BosEriko self-assigned this Mar 19, 2020
@BosEriko BosEriko added this to In progress in Discord Bot via automation Mar 19, 2020
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 19, 2020

Score: 0.78

Best reviewed: commit by commit


Optimal code review plan (2 warnings)

     move ping, server and args-info to its own component

     move avatar, kick and user-info to their own components

modularize the files

src/index.ts 76% changes removed in fix comments and add...

remove unwanted codes

src/index.ts 75% changes removed in update checkpoint

     remove the if-else chain

     update checkpoint

     remove .ts from file names

     fix comments and add rules link on the welcome message

Powered by Pull Assistant. Last update 29a2c95 ... 2e6573d. Read the comment docs.

@BosEriko BosEriko linked an issue that may be closed by this pull request Mar 19, 2020
@BosEriko BosEriko requested a review from ajsabandal Mar 19, 2020
Copy link
Contributor

NeonNature left a comment

LGTM

@BosEriko BosEriko merged commit a4f9e56 into kuru-project:master Mar 19, 2020
Discord Bot automation moved this from In progress to Done Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Discord Bot
  
Done
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.