Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem with node's `fs` so you can use it #14 #17

Conversation

@NeonNature
Copy link
Contributor

NeonNature commented Mar 25, 2020

Story Title

Fix the problem with node's fs so you can use it

Changes made

  • Removed array that list commands
  • Added automation that adds the command files using fs

How does the solution address the problem

This PR will solve #14 by adding command files with node's fs instead of defining them in an array.

@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 25, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     [Finishes #14] Automate adding command files

Powered by Pull Assistant. Last update ce5f14e ... ce5f14e. Read the comment docs.

@BosEriko BosEriko changed the title [Finishes #14] Automate adding command files Fix the problem with node's `fs` so you can use it #14 Mar 26, 2020
@BosEriko BosEriko self-requested a review Mar 26, 2020
@BosEriko BosEriko added this to In progress in Discord Bot via automation Mar 26, 2020
@BosEriko BosEriko added this to the MVP milestone Mar 26, 2020
@BosEriko BosEriko linked an issue that may be closed by this pull request Mar 26, 2020
Copy link
Member

BosEriko left a comment

LGTM

Discord Bot automation moved this from In progress to Reviewer approved Mar 26, 2020
@BosEriko BosEriko merged commit 82c03f2 into kuru-project:master Mar 26, 2020
Discord Bot automation moved this from Reviewer approved to Done Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Discord Bot
  
Done
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.