Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Twitter/Facebook/Discord on the Footer and Header #48 #65

Conversation

@BosEriko
Copy link
Member

BosEriko commented Mar 12, 2020

Story Title

Link Twitter/Facebook/Discord on the Footer and Header

Changes made

  • Create a SocialMedia component
  • Add Discord, Facebook, and Twitter on the SocialMedia component
  • Import SocialMedia to Footer and Header component

How does the solution address the problem

This PR will add links to our social media websites on the Footer and Header

@BosEriko BosEriko added this to the MVP milestone Mar 12, 2020
@BosEriko BosEriko self-assigned this Mar 12, 2020
@BosEriko BosEriko added this to In progress in Main Website Client via automation Mar 12, 2020
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Mar 12, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     add social media component and import it on footer and header

Powered by Pull Assistant. Last update d1835b8 ... d1835b8. Read the comment docs.

@now

This comment has been minimized.

Copy link

now bot commented Mar 12, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/kuru-project/main-website-client/7j11avkv4
Preview: https://main-website-c-git-issue-48-linktwitterfacebookdiscordon-6a646d.kuru-project.now.sh

@BosEriko BosEriko linked an issue that may be closed by this pull request Mar 12, 2020
@BosEriko BosEriko merged commit 575709c into master Mar 12, 2020
1 check passed
1 check passed
now Deployment has completed
Details
Main Website Client automation moved this from In progress to Done Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.