Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
The keyword "exists" can now search for array values #17
Allow Koncorde users to search for the existence of array values.
A new "array value" syntax has been added to the already existing nested field syntax:
The new array syntax allows looking for any scalar: boolean, numbers,
It is possible to mix nested field + array value syntaxes:
It is also possible to escape the array syntax, allowing to search for field keys named, for instance,
This new syntax can now be used with the
Also, the exists/missing keyword syntax has been simplified, from
Documentation PR: kuzzleio/documentation#532
How should this be manually tested?
Unit tests are already VERY thorough, but feel free to play with the new syntax :)
I was unable to get adequate performances while looking for array values, so I had to take a look at the overall Koncorde performances. I would never have thought that duplicating a
Also, I removed usages of the
@@ Coverage Diff @@ ## 1-dev #17 +/- ## ========================================== + Coverage 95.15% 95.18% +0.03% ========================================== Files 34 33 -1 Lines 1115 1081 -34 ========================================== - Hits 1061 1029 -32 + Misses 54 52 -2
Sorry for the lengthy PR, I had to improve many parts of Koncorde to make performances acceptable. I probably should have separated the perf. optimizations from the new array value syntax, but I didn't
So here are a few pointers to the interesting changes I made. You might want to focus on these.