New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document blocks list view #442

Merged
merged 7 commits into from Aug 29, 2018

Conversation

Projects
None yet
4 participants
@xbill82
Member

xbill82 commented Aug 27, 2018

depends on #441

What does this PR do ?

This PR introduces the document boxes view in the Document List.

How should this be manually tested?

  • Open the content of a non-empty collection in the Data section
  • Click on the "Blocks" icon on the right of the quick search filter
  • You should see the documents in form of blocks

@xbill82 xbill82 self-assigned this Aug 27, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 27, 2018

Codecov Report

Merging #442 into 2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x     #442   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files          35       35           
  Lines         780      780           
=======================================
  Hits          655      655           
  Misses        125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f245f16...2c29f87. Read the comment docs.

codecov-io commented Aug 27, 2018

Codecov Report

Merging #442 into 2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x     #442   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files          35       35           
  Lines         780      780           
=======================================
  Hits          655      655           
  Misses        125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f245f16...2c29f87. Read the comment docs.

Show outdated Hide outdated src/components/Data/Documents/DocumentBoxItem.vue Outdated
Show outdated Hide outdated src/components/Data/Documents/Page.vue Outdated
Show outdated Hide outdated src/components/Data/Documents/DocumentBoxItem.vue Outdated
<li class="divider"></li>
<li>
<a
v-bind:class="{'disabled': !canDelete}"

This comment has been minimized.

@Aschen

Aschen Aug 29, 2018

Contributor

If the user is not allowed to delete the document, he will still see the action button but there will be no effect on click. Maybe it's better to disable it if the user is not allowed to do this.

Despite this design cause an inconsistency between the list and map view and the block view because we are using a button for editing and a dropdown with the delete action for list and map and just a dropdown for block.
map view action button

@Aschen

Aschen Aug 29, 2018

Contributor

If the user is not allowed to delete the document, he will still see the action button but there will be no effect on click. Maybe it's better to disable it if the user is not allowed to do this.

Despite this design cause an inconsistency between the list and map view and the block view because we are using a button for editing and a dropdown with the delete action for list and map and just a dropdown for block.
map view action button

@Aschen

Aschen approved these changes Aug 29, 2018

xbill82 added some commits Aug 29, 2018

@Njuelle Njuelle merged commit 644a03d into 2.x Aug 29, 2018

4 checks passed

codecov/project 83.97% remains the same compared to f245f16
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@Njuelle Njuelle deleted the list-view-blocks branch Aug 29, 2018

@scottinet scottinet referenced this pull request Sep 12, 2018

Merged

Release 2.2.0 #451

@scottinet scottinet referenced this pull request Sep 26, 2018

Closed

Release 2.3.0 #462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment