New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KZL 305 - Visualize documents on a map #444

Merged
merged 24 commits into from Aug 29, 2018

Conversation

Projects
None yet
4 participants
@Aschen
Contributor

Aschen commented Aug 27, 2018

What does this PR do ?

This PR add a ViewMap component to display documents on a map.
The component use the documents geo_point to display markers on the map.
The user can choose which geo_point to use with a dropdown.
When you click on a marker, you can see the document content

How should this be manually tested?

  • Step 1 : Execute this script to have some geolocated data
  • Step 2 : Go to the collection view and select map view in the top right corner
  • Step 3 : Select some marker, you should see information about the document
  • Step 4 : Change the selected geopoint to emplacement instead of location

Other changes

Boyscout

  • fix bug in the throttle that cause inconcistency between the quick filter content and the url

Screenshots (if appropriate)

image

Aschen added some commits Aug 23, 2018

Add a ViewMap component
 - allow user to select which geo_point field to use

@Aschen Aschen self-assigned this Aug 27, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 27, 2018

Codecov Report

Merging #444 into 2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x     #444   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files          35       35           
  Lines         780      780           
=======================================
  Hits          655      655           
  Misses        125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644a03d...c9a97b4. Read the comment docs.

codecov-io commented Aug 27, 2018

Codecov Report

Merging #444 into 2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x     #444   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files          35       35           
  Lines         780      780           
=======================================
  Hits          655      655           
  Misses        125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644a03d...c9a97b4. Read the comment docs.

Aschen added some commits Aug 27, 2018

Aschen added some commits Aug 27, 2018

@Aschen Aschen changed the title from Kzl 305/visualize documents on a map to KZL 305 - Visualize documents on a map Aug 28, 2018

Aschen added some commits Aug 28, 2018

@Aschen Aschen removed need-ux wip labels Aug 28, 2018

@xbill82

Good job!

@@ -0,0 +1,25 @@
<template>

This comment has been minimized.

@xbill82

xbill82 Aug 28, 2018

Member

Lacks a comment here to explain what it is

@xbill82

xbill82 Aug 28, 2018

Member

Lacks a comment here to explain what it is

@@ -64,7 +64,7 @@ export default {
this.throttleSearch = true
setTimeout(() => {
this.throttleSearch = false
}, 200)
}, 50)

This comment has been minimized.

@xbill82

xbill82 Aug 28, 2018

Member

boyscouting?

@xbill82

xbill82 Aug 28, 2018

Member

boyscouting?

This comment has been minimized.

@Aschen

Aschen Aug 28, 2018

Contributor

Yes, they were inconsistency between the form and the url with a big timeout

@Aschen

Aschen Aug 28, 2018

Contributor

Yes, they were inconsistency between the form and the url with a big timeout

Show outdated Hide outdated src/components/Data/Documents/ListActions.vue Outdated
Show outdated Hide outdated src/components/Data/Documents/ListActions.vue Outdated
Show outdated Hide outdated src/components/Data/Documents/ListActions.vue Outdated
Show outdated Hide outdated src/components/Data/Documents/Page.vue Outdated
Show outdated Hide outdated src/components/Data/Documents/Page.vue Outdated
Show outdated Hide outdated src/components/Data/Documents/ViewMap.vue Outdated
Show outdated Hide outdated src/main.js Outdated
Show outdated Hide outdated src/main.js Outdated

@Aschen Aschen added wip and removed wip labels Aug 29, 2018

Aschen added some commits Aug 29, 2018

Aschen and others added some commits Aug 29, 2018

@xbill82

This comment has been minimized.

Show comment
Hide comment
@xbill82

xbill82 Aug 29, 2018

Member

@Aschen resolve your conflicts and merge 👍

Member

xbill82 commented Aug 29, 2018

@Aschen resolve your conflicts and merge 👍

@Njuelle Njuelle merged commit a20fa04 into 2.x Aug 29, 2018

4 checks passed

codecov/project 83.97% remains the same compared to 644a03d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@Njuelle Njuelle deleted the KZL-305/visualize-documents-on-a-map branch Aug 29, 2018

@scottinet scottinet referenced this pull request Sep 12, 2018

Merged

Release 2.2.0 #451

@scottinet scottinet referenced this pull request Sep 26, 2018

Closed

Release 2.3.0 #462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment