Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic list width #448

Merged
merged 11 commits into from Aug 30, 2018
Merged

Dynamic list width #448

merged 11 commits into from Aug 30, 2018

Conversation

xbill82
Copy link
Contributor

@xbill82 xbill82 commented Aug 30, 2018

What does this PR do ?

This PR tweaks the width of the list views (only in the Data section, for the moment) in order to make them narrower on large screens (which seemed not very meaningful and ugly).
It also introduces some horizontal layout fixes to bugs that showed up in my 13' Mac screen.

How should this be manually tested?

  • Open a collection on a large screen
  • You should see that the document list (and the Watch section) are narrower than the window and have some whitespace on the right

Other changes

  • Changing the width of the list containers also showed some layout weakness in some components. Some col s* m* l* xl* have been adjusted.

Boyscout

  • Added the missing vue2-leaflet package
  • Added some :key attributes to elements that had v-for

@codecov-io
Copy link

codecov-io commented Aug 30, 2018

Codecov Report

Merging #448 into 2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x     #448   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files          35       35           
  Lines         780      780           
=======================================
  Hits          655      655           
  Misses        125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1fcb8d...8ab89bd. Read the comment docs.

@xbill82 xbill82 merged commit a87d51e into 2.x Aug 30, 2018
@xbill82 xbill82 deleted the dynamic-list-width branch August 30, 2018 13:18
@scottinet scottinet mentioned this pull request Sep 12, 2018
@scottinet scottinet mentioned this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants