Please sign in to comment.
Fix URL parsing w/ trailing slash & querystring (#1539)
# Description Fix a bug where an URL containing both a trailing slash and a querystring would be incorrectly parsed. # How to reproduce The following HTTP GET request works fine: `http://localhost:7512/_now?pretty` But not this one without this PR: `http://localhost:7512/_now/?pretty` Both requests are equivalent and should be regarded as identical. # Other changes ~Use the WHATWG URL parsing API instead of the legacy (and deprecated) Node.js URL parser. Unfortunately, the latter was much more adapted to URL parsing server-side than the former.
😑~ Reverted to the legacy URL API because of: * nodejs/node#30334 (huge performance hit with WHATWG) * nodejs/node#30776 (bug with relative URLs starting with double-slashes)
- Loading branch information
Showing with 64 additions and 13 deletions.