Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the CLI to JS SDK 6-beta #1198

Merged
merged 2 commits into from Sep 26, 2018

Conversation

Projects
None yet
5 participants
@scottinet
Copy link
Member

commented Sep 26, 2018

What does this PR do?

The embedded Kuzzle JS SDK has been updated to v6 beta, which breaks the CLI.

This PR upgrades the CLI to the JS SDK 6

How should this be manually tested?

Use the CLI.

@jenow

jenow approved these changes Sep 26, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Sep 26, 2018

Codecov Report

Merging #1198 into 1-dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            1-dev    #1198   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files          95       95           
  Lines        6541     6541           
=======================================
  Hits         6147     6147           
  Misses        394      394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54382d8...48e4bbb. Read the comment docs.

@scottinet scottinet merged commit a7afee7 into 1-dev Sep 26, 2018

5 checks passed

LGTM analysis: JavaScript No alert changes
Details
codecov/project 93.97% remains the same compared to 54382d8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
sonarqube SonarQube reported no issues

@scottinet scottinet deleted the fix-cli branch Sep 26, 2018

@scottinet scottinet referenced this pull request Sep 26, 2018

Merged

Release 1.5.1 #1199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.