Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed mqtt #1223

Merged
merged 6 commits into from Dec 11, 2018

Conversation

Projects
None yet
6 participants
@benoitvidis
Copy link
Member

commented Dec 4, 2018

What does this PR do ?

This PR adds the MQTT protocol to Kuzzle core.

How to test it

You can have a look at the functional tests.

@@ -22,6 +22,7 @@ RUN set -x \
git \
python \
libfontconfig \
libzmq3-dev \

This comment has been minimized.

Copy link
@benoitvidis

benoitvidis Dec 4, 2018

Author Member

optional dependency for mosca server but throws an error during npm install if missing.

@benoitvidis benoitvidis added the wip label Dec 5, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Dec 5, 2018

Codecov Report

Merging #1223 into 1-dev will decrease coverage by 0.02%.
The diff coverage is 91.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##            1-dev    #1223      +/-   ##
==========================================
- Coverage   93.88%   93.85%   -0.03%     
==========================================
  Files          95       96       +1     
  Lines        6555     6642      +87     
==========================================
+ Hits         6154     6234      +80     
- Misses        401      408       +7
Impacted Files Coverage Δ
lib/api/core/entrypoints/embedded/index.js 97.12% <50%> (-1.11%) ⬇️
...ib/api/core/entrypoints/embedded/protocols/mqtt.js 93.97% <93.97%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9604e3d...e1e2def. Read the comment docs.

@benoitvidis benoitvidis removed the wip label Dec 5, 2018

@scottinet
Copy link
Member

left a comment

The file .kuzzlerc.sample needs to be updated.

@scottinet scottinet changed the title Embedd mqtt Embed mqtt Dec 6, 2018

@jenow

jenow approved these changes Dec 7, 2018

@Aschen
Copy link
Contributor

left a comment

What about the MQTT protocol readme ? Should'nt we keep it somewhere ? In the documentation maybe ?
And I think the PR deserve a new-feature label 😀

@Aschen

Aschen approved these changes Dec 11, 2018

@scottinet scottinet merged commit 6940142 into 1-dev Dec 11, 2018

5 checks passed

LGTM analysis: JavaScript No alert changes
Details
codecov/project 93.85% (-0.03%) compared to 9604e3d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
sonarqube SonarQube reported no issues

@scottinet scottinet deleted the kzl-674-embedd-mqtt branch Dec 11, 2018

@benoitvidis benoitvidis referenced this pull request Jan 23, 2019

Merged

Release 1.6.0 #1238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.