Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Es aliases compatibility #1231

Merged
merged 4 commits into from Jan 17, 2019
Merged

Es aliases compatibility #1231

merged 4 commits into from Jan 17, 2019

Conversation

benoitvidis
Copy link
Contributor

What does this PR do ?

This PR adds a minimal level of compatibility with Elasticsearch aliases.
This PR does not implement management of aliases

@kuzzle
Copy link
Contributor

kuzzle commented Jan 15, 2019

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. INFO index.js#L104: Complete the task associated to this TODO comment. rule

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #1231 into 1-dev will decrease coverage by 0.06%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##            1-dev   #1231      +/-   ##
=========================================
- Coverage   93.87%   93.8%   -0.07%     
=========================================
  Files          97      97              
  Lines        6673    6681       +8     
=========================================
+ Hits         6264    6267       +3     
- Misses        409     414       +5
Impacted Files Coverage Δ
lib/services/internalEngine/index.js 81.56% <0%> (-3%) ⬇️
lib/api/core/indexCache.js 97.72% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f216b87...f8374e8. Read the comment docs.

@alexandrebouthinon alexandrebouthinon merged commit fb65afb into 1-dev Jan 17, 2019
@alexandrebouthinon alexandrebouthinon deleted the es-alias-compatibility branch January 17, 2019 09:24
@benoitvidis benoitvidis mentioned this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants