Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Allow configuration of CORS methods & headers #1259

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
5 participants
@benoitvidis
Copy link
Member

commented Mar 11, 2019

This PR makes the CORS headers Accept-Control-Allow-Methods and Accept-Control-Allow-Headers configurable.

Related issue: #1258

@codecov-io

This comment has been minimized.

Copy link

commented Mar 11, 2019

Codecov Report

Merging #1259 into 1-dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            1-dev    #1259   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files          97       97           
  Lines        6705     6705           
=======================================
  Hits         6288     6288           
  Misses        417      417
Impacted Files Coverage Δ
lib/api/core/httpRouter/index.js 98.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b629ce4...1a39c0b. Read the comment docs.

@Aschen

Aschen approved these changes Mar 12, 2019

@Aschen

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

You could also make Access-Control-Expose-Headers configurable as well

@scottinet
Copy link
Member

left a comment

In retrospect, this should have been the case since the very beginning 😑

@alexandrebouthinon alexandrebouthinon merged commit b272b1f into 1-dev Mar 14, 2019

5 checks passed

LGTM analysis: JavaScript No new or fixed alerts
Details
codecov/project 93.78% remains the same compared to b629ce4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
sonarqube SonarQube reported no issues

@alexandrebouthinon alexandrebouthinon deleted the feature/cors branch Mar 14, 2019

@scottinet scottinet referenced this pull request Mar 26, 2019

Merged

Release 1.7.0 #1274

scottinet added a commit that referenced this pull request Mar 26, 2019

Merge pull request #1274 from kuzzleio/1.7.0-proposal
# [1.7.0](https://github.com/kuzzleio/kuzzle/releases/tag/1.7.0) (2019-03-26)


#### Bug fixes

- [ [#1263](#1263) ] Change start sequence for mappings, fixtures and securities   ([Aschen](https://github.com/Aschen))
- [ [#1269](#1269) ] Fix aggregations for the security:searchXxx API routes   ([jenow](https://github.com/jenow))
- [ [#1267](#1267) ] Fix the "IsAuthenticated" assertion   ([scottinet](https://github.com/scottinet))
- [ [#1266](#1266) ] Fix controllers action leak   ([scottinet](https://github.com/scottinet))

#### New features

- [ [#1265](#1265) ] KZL-508 - auth:refreshToken   ([benoitvidis](https://github.com/benoitvidis), [scottinet](https://github.com/scottinet))

#### Enhancements

- [ [#1245](#1245) ] KZL-1005 -  Add method to use request context in SDK queries   ([Aschen](https://github.com/Aschen))
- [ [#1255](#1255) ] Add loading of fixtures mappings securities admin controller   ([Aschen](https://github.com/Aschen))
- [ [#1259](#1259) ] [http] Allow configuration of CORS methods & headers   ([benoitvidis](https://github.com/benoitvidis))
- [ [#1250](#1250) ] Make "collection:getSpecifications" error messages meaningful   ([scottinet](https://github.com/scottinet))

#### Others

- [ [#1271](#1271) ] [ci] Optimize build time and number of runners   ([alexandrebouthinon](https://github.com/alexandrebouthinon))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.