Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong return value for collection:truncate #1380

Merged
merged 4 commits into from Aug 12, 2019

Conversation

@Aschen
Copy link
Contributor

commented Aug 6, 2019

What does this PR do ?

Currently collection:truncate returns the list of deleted document IDs.
This PR change the return value to match the documentation with { acknowledged: true }

@Aschen Aschen self-assigned this Aug 6, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 6, 2019

Codecov Report

Merging #1380 into 1-dev will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            1-dev    #1380      +/-   ##
==========================================
- Coverage   93.92%   93.89%   -0.04%     
==========================================
  Files         106      106              
  Lines        7328     7316      -12     
==========================================
- Hits         6883     6869      -14     
- Misses        445      447       +2
Impacted Files Coverage Δ
lib/api/controllers/collectionController.js 100% <100%> (ø) ⬆️
lib/config/error-codes/throw.js 90.47% <0%> (-9.53%) ⬇️
lib/api/controllers/baseController.js 91.3% <0%> (-8.7%) ⬇️
lib/api/controllers/adminController.js 93.42% <0%> (-0.17%) ⬇️
lib/api/controllers/authController.js 95.71% <0%> (-0.07%) ⬇️
lib/api/controllers/securityController.js 98.31% <0%> (-0.04%) ⬇️
lib/api/controllers/serverController.js 91.78% <0%> (ø) ⬆️
lib/api/controllers/realtimeController.js 96.77% <0%> (ø) ⬆️
lib/api/controllers/memoryStorageController.js 99.09% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78aa09...578fdf3. Read the comment docs.

Aschen added 2 commits Aug 6, 2019
…urn-collection-truncate
@jenow
jenow approved these changes Aug 9, 2019
@Aschen Aschen merged commit 5c87d79 into 1-dev Aug 12, 2019
5 of 8 checks passed
5 of 8 checks passed
Header rules No header rules processed
Details
Pages changed 445 new files uploaded
Details
Redirect rules No redirect rules processed
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
sonarqube SonarQube reported no issues
@Aschen Aschen deleted the fix-wrong-return-collection-truncate branch Aug 12, 2019
@Aschen Aschen changed the title Fix wrong return value from collection truncate Fix wrong return value for collection:truncate Aug 12, 2019
Yoann-Abbes added a commit that referenced this pull request Aug 20, 2019
Currently collection:truncate returns the list of deleted document IDs.
This PR change the return value to match the documentation with { acknowledged: true }
@Aschen Aschen referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.