Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subcode to ESWrapper #1390

Merged
merged 9 commits into from Aug 20, 2019

Conversation

@Aschen
Copy link
Contributor

commented Aug 14, 2019

What does this PR do ?

Add subcode to ESWrapper

Other changes

  • change errorName from domain-subdomain-error to domain.subdomain.error (eg: errorName: 'external.elasticsearch.index_or_collection_does_not_exist')
wip
@Aschen Aschen self-assigned this Aug 14, 2019
@Aschen Aschen added the wip label Aug 14, 2019
@Aschen Aschen removed the wip label Aug 14, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 14, 2019

Codecov Report

Merging #1390 into 1-dev will decrease coverage by 16.57%.
The diff coverage is 7.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           1-dev    #1390       +/-   ##
==========================================
- Coverage     94%   77.43%   -16.58%     
==========================================
  Files        106      106               
  Lines       7376     7396       +20     
==========================================
- Hits        6934     5727     -1207     
- Misses       442     1669     +1227
Impacted Files Coverage Δ
lib/config/error-codes/throw.js 100% <100%> (ø) ⬆️
lib/util/esWrapper.js 12.5% <4.87%> (-83.66%) ⬇️
lib/services/garbageCollector.js 0% <0%> (-97.78%) ⬇️
lib/services/broker/wsBrokerServer.js 5.78% <0%> (-93.39%) ⬇️
lib/services/elasticsearch.js 2.61% <0%> (-89.35%) ⬇️
lib/services/redis.js 6.49% <0%> (-81.82%) ⬇️
lib/services/internalEngine/bootstrap.js 9.37% <0%> (-81.25%) ⬇️
lib/services/index.js 15.55% <0%> (-80%) ⬇️
lib/services/broker/wsBrokerClient.js 19.72% <0%> (-75.52%) ⬇️
lib/services/internalEngine/pluginBootstrap.js 26.31% <0%> (-68.43%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c87d79...fc36ba6. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Aug 14, 2019

Codecov Report

Merging #1390 into 1-dev will decrease coverage by 0.16%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           1-dev    #1390      +/-   ##
=========================================
- Coverage     94%   93.84%   -0.17%     
=========================================
  Files        106      106              
  Lines       7376     7393      +17     
=========================================
+ Hits        6934     6938       +4     
- Misses       442      455      +13
Impacted Files Coverage Δ
lib/config/error-codes/throw.js 100% <100%> (ø) ⬆️
lib/util/esWrapper.js 78.87% <65%> (-17.29%) ⬇️
lib/api/core/sandbox/index.js 88% <0%> (ø) ⬆️
lib/api/core/validation/index.js 98.72% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c87d79...79583d9. Read the comment docs.

Aschen added 3 commits Aug 14, 2019
Copy link
Member

left a comment

You must remove package-lock.json from updated files.
There is also something weird about changes on Auth Local plugin.

Aschen added 2 commits Aug 20, 2019
@Aschen

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

You must remove package-lock.json from updated files.
There is also something weird about changes on Auth Local plugin.

@alexandrebouthinon fixed

@alexandrebouthinon alexandrebouthinon merged commit 3f40df8 into 1-dev Aug 20, 2019
6 of 9 checks passed
6 of 9 checks passed
Header rules No header rules processed
Details
Pages changed 451 new files uploaded
Details
Redirect rules No redirect rules processed
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
codecov/project 93.84% (-0.17%) compared to 5c87d79
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
sonarqube SonarQube reported no issues
@alexandrebouthinon alexandrebouthinon deleted the add-subcode-to-es-wrapper branch Aug 20, 2019
@Aschen Aschen referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.