Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init indices containing a dot #1455

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@benoitvidis
Copy link
Member

commented Sep 9, 2019

What does this PR do ?

This PR fixes the case where Kuzzle would crash on start because of some existing elasticsearch indices containing a dot (.) in their name.

NB: does not apply to 2-dev

@codecov

This comment has been minimized.

Copy link

commented Sep 9, 2019

Codecov Report

Merging #1455 into 1-dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            1-dev    #1455      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         106      106              
  Lines        7428     7430       +2     
==========================================
+ Hits         6970     6972       +2     
  Misses        458      458
Impacted Files Coverage Δ
lib/util/esWrapper.js 79.45% <100%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e900d8...03bd45c. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Sep 9, 2019

Codecov Report

Merging #1455 into 1-dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            1-dev    #1455      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         106      106              
  Lines        7428     7430       +2     
==========================================
+ Hits         6970     6972       +2     
  Misses        458      458
Impacted Files Coverage Δ
lib/util/esWrapper.js 79.45% <100%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e900d8...03bd45c. Read the comment docs.

@Aschen
Aschen approved these changes Sep 9, 2019
@@ -98,6 +98,8 @@ jobs:
cache:
directories:
- $HOME/.gem/specs
env:
- REPOSITORIES=kuzzle-how-to,sdk-javascript-5,sdk-javascript-6,plugin-s3-1,sdk-php-3,plugin-cloudinary-1,sdk-cpp-1,sdk-csharp-1,sdk-go-1,sdk-go-2,sdk-java-1,sdk-java-2,sdk-java-3,kuzzle-1,sdk-android-3,plugin-multi-tenancy-1

This comment has been minimized.

Copy link
@benoitvidis

benoitvidis Sep 9, 2019

Author Member

Do not test 2-dev dead links on 1-dev branch

@Aschen Aschen merged commit 7f804af into 1-dev Sep 9, 2019
6 of 9 checks passed
6 of 9 checks passed
Header rules No header rules processed
Details
Pages changed 456 new files uploaded
Details
Redirect rules No redirect rules processed
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
codecov/project 93.83% (+<.01%) compared to 2e900d8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
sonarqube SonarQube reported no issues
@Aschen Aschen referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.