Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add more security actions logs #1563
What does this PR do ?
This PR adds logs on security actions who modify either a role, a profile or a user.
How should this be manually tested?
Add a new
@@ Coverage Diff @@ ## 2-dev #1563 +/- ## ========================================== - Coverage 93.66% 93.53% -0.13% ========================================== Files 102 102 Lines 6899 6964 +65 ========================================== + Hits 6462 6514 +52 - Misses 437 450 +13
scottinet left a comment
To prevent subtle bugs to occur (see @Aschen comments, and mines too), I'll prefer if you replace only "delete" with "= undefined" for objects created on the fly. For RAM caches, you should instead replace JSON objects with Maps (which are designed to contain volatile data).