Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React native compatibility #355

Merged
merged 14 commits into from Jan 10, 2019

Conversation

Projects
None yet
5 participants
@scottinet
Copy link
Member

commented Jan 8, 2019

Description

Fixes the following issues:

  • Symbol is not supported in older versions of React Native:
    • all usages of that keyword have been removed from the source code
    • force babel to consider all instances of for...of to be applied to arrays only, preventing it to use Symbol iterators
  • babel was incorrectly configured in webpack, and so it was ignored. Now that babel is properly applied, the built library size increases from 55ko to 95ko, approx.
  • create a dedicated babel configuration file, to properly separate webpack from babel

@scottinet scottinet self-assigned this Jan 8, 2019

@scottinet scottinet added the wip label Jan 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 9, 2019

Codecov Report

Merging #355 into 6-dev will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            6-dev     #355      +/-   ##
==========================================
- Coverage   96.61%   96.59%   -0.03%     
==========================================
  Files          28       28              
  Lines        1419     1409      -10     
==========================================
- Hits         1371     1361      -10     
  Misses         48       48
Impacted Files Coverage Δ
src/controllers/bulk.js 100% <100%> (ø) ⬆️
src/controllers/server.js 100% <100%> (ø) ⬆️
src/controllers/security/index.js 100% <100%> (ø) ⬆️
src/controllers/collection.js 94.8% <100%> (-0.07%) ⬇️
src/controllers/base.js 100% <100%> (ø) ⬆️
src/controllers/realtime/index.js 100% <100%> (ø) ⬆️
src/controllers/memoryStorage.js 96.25% <100%> (-0.05%) ⬇️
src/controllers/document.js 94.82% <100%> (-0.03%) ⬇️
src/controllers/auth.js 92.3% <100%> (-0.2%) ⬇️
src/protocols/websocket.js 98.07% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db802ae...23bec1f. Read the comment docs.

scottinet added some commits Jan 9, 2019

wtf

@scottinet scottinet removed the wip label Jan 9, 2019

Show resolved Hide resolved webpack.config.js Outdated

@kuzzleio kuzzleio deleted a comment from scottinet Jan 10, 2019

Show resolved Hide resolved webpack.config.js Outdated

xbill82 and others added some commits Jan 10, 2019

Update webpack.config.js
Co-Authored-By: scottinet <seb.cottinet@gmail.com>

@xbill82 xbill82 merged commit e130e2a into 6-dev Jan 10, 2019

3 checks passed

codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +3.38% compared to db802ae
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@xbill82 xbill82 deleted the react-native-compat branch Jan 10, 2019

This was referenced Jan 17, 2019

@alexandrebouthinon alexandrebouthinon referenced this pull request Feb 21, 2019

Merged

6.0.0 proposal #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.