Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New params syntax & request body handling #5

Closed
4 tasks done
kuzznya opened this issue Jul 22, 2020 · 4 comments
Closed
4 tasks done

New params syntax & request body handling #5

kuzznya opened this issue Jul 22, 2020 · 4 comments
Assignees
@kuzznya
Labels
enhancement New feature or request

Comments

@kuzznya
Copy link
Owner

kuzznya commented Jul 22, 2020 •
edited
Loading

For more complex request handling actions, such as getting data from body, new syntax is required

Some ideas:

params:
  arg0: textArg
  arg1: {{ params.someVal }}
  user: {{ body.username }}
  data: {{ body }}
  • New syntax
  • Split parsing & evaluation
  • Request body handling
  • Cover with tests
@kuzznya kuzznya added the enhancement New feature or request label Jul 22, 2020
@kuzznya kuzznya self-assigned this Jul 22, 2020
kuzznya added a commit that referenced this issue Jul 26, 2020
@kuzznya
feat: Method parameter evaluator with request & path params
46fcdfd 
Use more complex evaluation of method params
Enable use of both path & request params
Support multi-value request params (as List of values)
(issue #5)
@kuzznya
Copy link
Owner Author

kuzznya commented Jul 27, 2020

Split params parsing & evaluation to decrease response time (do parsing only at start)

@kuzznya
Copy link
Owner Author

kuzznya commented Jul 27, 2020

SpEL - use or not to use?

kuzznya added a commit that referenced this issue Aug 10, 2020
@kuzznya
feat: Improve performance of evaluation
20cfea6 
* Save parsed expressions in Map to use them later
instead of parsing again
* Enable request data change without creating new Evaluator
to save constructed Context & expressions cache

(issue #5)
kuzznya added a commit that referenced this issue Aug 11, 2020
@kuzznya
feat: Use evaluator for params in config
2902156 
Use ParameterEvaluator in EndpointHandler to evaluate method params
using request data

issue #5
kuzznya added a commit that referenced this issue Aug 11, 2020
@kuzznya
feat: Enable body data handling
5061deb 
Deserialize body as map & handle $(bodyData['<key>']) params

issue #5 (body handling)
kuzznya added a commit that referenced this issue Aug 11, 2020
@kuzznya
feat: Enable body deserialization
a5dd314 
Enable requestBodyClass param in endpoint config &
deserialize body using that class

issue #5 (body handling)
@kuzznya
Copy link
Owner Author

kuzznya commented Aug 11, 2020

Syntax $(...) is redundant
Better use : params['val'] without $(...)

@kuzznya kuzznya mentioned this issue Aug 11, 2020
Closed
@kuzznya
Copy link
Owner Author

kuzznya commented Aug 11, 2020

Seems that all is done here

@kuzznya kuzznya closed this as completed Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuzznya kuzznya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kuzznya