From 96366a30f624e3ef8c4cd672690075c5410ee460 Mon Sep 17 00:00:00 2001 From: Kai Vehmanen Date: Fri, 30 Dec 2022 14:30:44 +0200 Subject: [PATCH] drivers: dai: intel: dmic: don't use assert for error handling The dai.h interface does not prohibit calling dai_config_get() with different direction values. The dmic driver should handle invalid direction value explicitly and not rely on an assert. Link: https://github.com/thesofproject/sof/issues/6896 Signed-off-by: Kai Vehmanen --- drivers/dai/intel/dmic/dmic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dai/intel/dmic/dmic.c b/drivers/dai/intel/dmic/dmic.c index 606298ed9670e9..b82e3b6d3fe609 100644 --- a/drivers/dai/intel/dmic/dmic.c +++ b/drivers/dai/intel/dmic/dmic.c @@ -743,7 +743,9 @@ static const struct dai_config *dai_dmic_get_config(const struct device *dev, en { struct dai_intel_dmic *dmic = (struct dai_intel_dmic *)dev->data; - __ASSERT_NO_MSG(dir == DAI_DIR_RX); + if (dir != DAI_DIR_RX) + return NULL; + return &dmic->dai_config_params; }