Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jun 18, 2010
  1. @utrace

    sched: Remove the obsolete exit_state/signal hacks

    utrace authored Ingo Molnar committed
    account_group_xxx() functions check ->exit_state to ensure that
    current->signal is valid and can't go away. This is not needed
    since ea6d290, task->signal is pinned to task_struct.
    
    The comment and another hack in account_group_exec_runtime() refers
    to task_rq_unlock_wait() which was already removed by b7b8ff6.
    
    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    LKML-Reference: <20100610230952.GA25914@redhat.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
Commits on Nov 17, 2008
  1. @utrace

    sched, signals: fix the racy usage of ->signal in account_group_xxx/r…

    utrace authored Ingo Molnar committed
    …un_posix_cpu_timers
    
    Impact: fix potential NULL dereference
    
    Contrary to ad474ca changelog, other
    acct_group_xxx() helpers can be called after exit_notify() by timer tick.
    Thanks to Roland for pointing out this. Somehow I missed this simple fact
    when I read the original patch, and I am afraid I confused Frank during
    the discussion. Sorry.
    
    Fortunately, these helpers work with current, we can check ->exit_state
    to ensure that ->signal can't go away under us.
    
    Also, add the comment and compiler barrier to account_group_exec_runtime(),
    to make sure we load ->signal only once.
    
    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
Something went wrong with that request. Please try again.