Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRead/Write iterators #12
Conversation
This comment has been minimized.
This comment has been minimized.
|
Well, I like it more than my attempt :) |
torkleyy
reviewed
May 2, 2017
README.md
Outdated
| [](https://crates.io/crates/froggy) | ||
| [](https://gitter.im/almost-ecs?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kvark
force-pushed the
iter
branch
from
807733e
to
2560977
May 2, 2017
kvark
force-pushed the
iter
branch
from
2560977
to
12487c3
May 2, 2017
kvark
added some commits
May 3, 2017
torkleyy
reviewed
May 3, 2017
| return None | ||
| } | ||
| self.index += 1; | ||
| if !self.skip_lost || self.lock.guard.meta[id] != 0 { |
This comment has been minimized.
This comment has been minimized.
torkleyy
May 3, 2017
Contributor
Do you think the compiler can move the branch out of the loop or should we have ReadIterAlive?
This comment has been minimized.
This comment has been minimized.
kvark
May 3, 2017
Author
Owner
I don't think this is a big performance concern at the moment. If not anything else, the hardware CPU branch predictor will remember to always go the right path
This comment has been minimized.
This comment has been minimized.
|
Ok, I believe that everyone had a chance to look at this:
|
kvark
merged commit 92a10e1
into
master
May 5, 2017
kvark
deleted the
iter
branch
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kvark commentedMay 2, 2017
Replaces #11
Fixes #8
The only (and important) downside of the PR is the introduction of
unsafecode forWriteItem.