Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove all the locks #33
Conversation
kvark
added some commits
May 12, 2017
This comment has been minimized.
This comment has been minimized.
|
The biggest issue I see with this PR is a bit of uncertainty about when the pending updates are applied. But that wasn't set in stone anyway, so I hope we can get a nice model and apply fixes as follow-ups. |
vitvakatu
approved these changes
May 12, 2017
|
Great |
kvark
merged commit 70f2738
into
master
May 12, 2017
kvark
deleted the
lock
branch
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kvark commentedMay 12, 2017
No description provided.