Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDeferred epoch initialization #37
Conversation
kvark
referenced this pull request
May 13, 2017
Merged
Convenience implementations of FromIterator/IntoIterator #39
vitvakatu
reviewed
May 13, 2017
src/lib.rs
Outdated
| fun(&mut *pending) | ||
| } | ||
|
|
||
| /// Wait for all the pending updates. | ||
| pub fn wait(&mut self) { | ||
| /// Syncrhonize for all the pending updates. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kvark
force-pushed the
epoch
branch
from
7eaf447
to
032dadf
May 14, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks, fixed! |
kvark
merged commit 9b44147
into
master
May 14, 2017
kvark
deleted the
epoch
branch
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kvark commentedMay 13, 2017
Fixes #29
Our
createfunction is pretty lightweight now: checking a few conditions and adding a single reference. No locking or other heavy operations.Performance before:
After:
Looks like a solid win (1.5x on ecs_pos_vel).