Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upModernized ray-tracing #62
Conversation
This comment has been minimized.
This comment has been minimized.
kvark
added some commits
Dec 30, 2018
kvark
force-pushed the
mipmap
branch
from
741c37a
to
772b457
Jan 2, 2019
kvark
added some commits
Jan 3, 2019
This comment has been minimized.
This comment has been minimized.
kvark
changed the title
[WIP] Modernized ray-tracing
Modernized ray-tracing
Jan 4, 2019
This comment has been minimized.
This comment has been minimized.
kvark
added some commits
Jan 4, 2019
kvark
force-pushed the
mipmap
branch
from
6e6f107
to
6c43f8c
Jan 4, 2019
kvark
added some commits
Jan 4, 2019
kvark
force-pushed the
mipmap
branch
from
3c7656b
to
977ce98
Jan 4, 2019
This comment has been minimized.
This comment has been minimized.
|
I think the change is basically done. Of course quality/performance improvements are possible here and there, but this will always be the case. The biggest concern is currently the portability of the change:
With this in mind, I think we should proceed with the change, considering the follow-ups:
|
This comment has been minimized.
This comment has been minimized.
|
Alright, I did the most reasonable thing for portability - brought back the old ray tracer, just as a fallback option. Time to ship this! |
bors bot
added a commit
that referenced
this pull request
Jan 4, 2019
This comment has been minimized.
This comment has been minimized.
Build succeeded |
kvark
referenced this pull request
Jan 5, 2019
Merged
Don't create SRVs of the height for mipmapping #64
bors bot
added a commit
that referenced
this pull request
Jan 5, 2019
bors bot
added a commit
that referenced
this pull request
Jan 5, 2019
kvark
deleted the
mipmap
branch
Jan 5, 2019
bors bot
added a commit
that referenced
this pull request
Jan 6, 2019
kvark
referenced this pull request
Mar 20, 2019
Closed
Re-implement the maximum mipmap raytracer #74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.



kvark commentedJan 1, 2019
•
edited
Algorithm is based on Maximum Mipmaps for Fast, Accurate, and Scalable Dynamic Height Field Rendering.