From f2f7cf1d45fb4d1c466fa1caf82c25d4f00dc1c1 Mon Sep 17 00:00:00 2001
From: Janne Vanhala <jpvanhal@users.noreply.github.com>
Date: Thu, 27 Apr 2023 14:15:52 +0300
Subject: [PATCH] Use custom SQL construct for refreshing materialized views
 (#703)

Add a custom SQL construct, `RefreshMaterializedView`, to compile the
SQL for `REFRESH MATERIALIZED VIEW ...` command. Use the SQL construct
in `refresh_materialized_view` function to execute the SQL. This
resolves an issue where `refresh_materialized_view` crashed with
`AttributeError: 'NoneType' object has no attribute 'engine'` when using
Flask-SQLAlchemy 3.0 where `session.bind` is `None`.
---
 sqlalchemy_utils/view.py | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/sqlalchemy_utils/view.py b/sqlalchemy_utils/view.py
index 96103db1..96cbe36c 100644
--- a/sqlalchemy_utils/view.py
+++ b/sqlalchemy_utils/view.py
@@ -1,6 +1,7 @@
 import sqlalchemy as sa
 from sqlalchemy.ext import compiler
 from sqlalchemy.schema import DDLElement, PrimaryKeyConstraint
+from sqlalchemy.sql.expression import ClauseElement, Executable
 
 from sqlalchemy_utils.functions import get_columns
 
@@ -178,6 +179,22 @@ def create_indexes(target, connection, **kw):
     return table
 
 
+class RefreshMaterializedView(Executable, ClauseElement):
+    inherit_cache = True
+
+    def __init__(self, name, concurrently):
+        self.name = name
+        self.concurrently = concurrently
+
+
+@compiler.compiles(RefreshMaterializedView)
+def compile_refresh_materialized_view(element, compiler):
+    return 'REFRESH MATERIALIZED VIEW {concurrently}{name}'.format(
+        concurrently='CONCURRENTLY ' if element.concurrently else '',
+        name=compiler.dialect.identifier_preparer.quote(element.name),
+    )
+
+
 def refresh_materialized_view(session, name, concurrently=False):
     """ Refreshes an already existing materialized view
 
@@ -190,9 +207,4 @@ def refresh_materialized_view(session, name, concurrently=False):
     # Since session.execute() bypasses autoflush, we must manually flush in
     # order to include newly-created/modified objects in the refresh.
     session.flush()
-    session.execute(
-        sa.text('REFRESH MATERIALIZED VIEW {}{}'.format(
-            'CONCURRENTLY ' if concurrently else '',
-            session.bind.engine.dialect.identifier_preparer.quote(name)
-        ))
-    )
+    session.execute(RefreshMaterializedView(name, concurrently))