New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash by a Client Known with User-Agent Avira #8

Closed
kvic-z opened this Issue Dec 9, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@kvic-z
Copy link
Owner

kvic-z commented Dec 9, 2017

Client

Unsure but with User-Agent known as 'Avira'.

Symptom

pixelserv-tls v2.0.1-rc2 crashes when the client tries to POST contents.

The request that caused crash

'POST /engage/ HTTP/1.1
Host: api.mixpanel.com
User-Agent: Avira
Accept: */*
Content-Length:2130
Content-Type: application/x-www-form-urlencoded
Expect: 100-continue

'
socket:22 host:api.mixpanel.com
method: 'POST'
Segmentation fault
@kvic-z

This comment has been minimized.

Copy link
Owner Author

kvic-z commented Dec 9, 2017

Analysis

No space between 'Content-Length:' and '2130'. I believe the standard requires a space in-between. Anyway pixelserv-tls shall have been more resilient in such case.

@kvic-z

This comment has been minimized.

Copy link
Owner Author

kvic-z commented Dec 11, 2017

Fixed in 0063f766

@kvic-z kvic-z closed this Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment