New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile against musl #16

Merged
merged 5 commits into from Jul 14, 2018

Conversation

Projects
None yet
2 participants
@JohnNilsson
Copy link

JohnNilsson commented Jul 12, 2018

Just started playing around with this and had some fun getting things to compile on apline linux (using musl).

Not really a C-coder so probably don't know what I'm doing. But if you have the time I would appreciate some feedback on these changes. Mostly aiming towards two goals, make visual studio code not show warnings, and make the following docker build complete successfully.

FROM alpine:latest as builder

RUN apk add --no-cache autoconf automake build-base libressl-dev linux-headers

COPY pixelserv-tls/ /usr/src/pixelserv-tls

ENV CFLAGS -Wextra -flto

WORKDIR /usr/src/pixelserv-tls
RUN set -ex; autoreconf -i; ./configure; make

(the err thing was due to a linker warning about it being redefined, I don't expect this to be merged as is as the comment states, a struct is probably a better approach)

@kvic-z kvic-z merged commit 755be89 into kvic-z:master Jul 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kvic-z

This comment has been minimized.

Copy link
Owner

kvic-z commented Jul 14, 2018

Thank you for the MUSL patch, and bringing pixelserv-tls to Alpine Linux.

Do you have plan to maintain a binary package for Alpine Linux users?
I could add it to supported platforms if you let me know the details.

@JohnNilsson

This comment has been minimized.

Copy link
Author

JohnNilsson commented Jul 14, 2018

Not for now. Just playing around with containers for my own amusement at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment