Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not track Linux kernel version #2411

Merged
merged 1 commit into from Nov 24, 2018
Merged

Do not track Linux kernel version #2411

merged 1 commit into from Nov 24, 2018

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Nov 17, 2018 •
edited

Do not track Linux kernel version
of build system to make reproducible builds easier.

See https://reproducible-builds.org/ for why this is good.

Needed because otherwise there were variations from

-set(CMAKE_SYSTEM "Linux-4.19.1-1-default")             
+set(CMAKE_SYSTEM "Linux-4.12.14-lp150.12.25-default")
-set(CMAKE_SYSTEM_VERSION "4.19.1-1-default")           
+set(CMAKE_SYSTEM_VERSION "4.12.14-lp150.12.25-default")

Code was simplified by also dropping it on MSWindows

This PR was done while working on reproducible builds for openSUSE.

@bmwiedemann
Do not track Linux kernel version
6eeddab 
of build system to make reproducible builds easier.

See https://reproducible-builds.org/ for why this is good.
@DarthGandalf DarthGandalf merged commit 7e4dccb into kvirc:master Nov 24, 2018
@bmwiedemann bmwiedemann deleted the uname branch March 24, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarthGandalf DarthGandalf DarthGandalf left review comments

@Stanzilla Stanzilla Stanzilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bmwiedemann @Stanzilla @DarthGandalf