Because GLOBAL is deprecated in node #303

Merged
merged 1 commit into from Aug 9, 2016

Projects

None yet

2 participants

@DracoBlue
Contributor
DracoBlue commented Aug 8, 2016 edited
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

"(node:1) DeprecationWarning: 'GLOBAL' is deprecated, use 'global'"
@kvz
Owner
kvz commented Aug 9, 2016

Thanks for you PR! It seems this happened going from Node 5->6: https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6

A few things:

  • Locutus targets node v4 currently
  • it seems v4 already supports lowercase global, so we might be able to support v4-6 by using it
  • if we're switching to lowercase global, it would need to be implemented across the board, and not just in src/php/var/unserialize.js
  • would you expand your PR to do this in all cases? If so, I'm happy to merge. Otherwise I'll have a look soonish myself!
@DracoBlue
Contributor

I will try a quick sed replace on the cli and update the PR asap

Am 09.08.2016 9:54 vorm. schrieb "Kevin van Zonneveld" <
notifications@github.com>:

Thanks for you PR! It seems this happened going from Node 5->6:
https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6

A few things:

Locutus targets node v4 currently
it seems v4 already supports lowercase global, so we might be able to
support v4-6 by using it
if we're switching to lowercase global, it would need to be implemented
across the board, and not just in src/php/var/unserialize.js
would you expand your PR to do this in all cases? If so, I'm happy to
merge. Otherwise I'll have a look soonish myself!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@DracoBlue DracoBlue Because GLOBAL is deprecated in node
```
"(node:1) DeprecationWarning: 'GLOBAL' is deprecated, use 'global'"
```
d200696
@DracoBlue
Contributor

@kvz I updated the PR to replace GLOBAL to global in all files (except website - is this necessary?)

@kvz
Owner
kvz commented Aug 9, 2016

Hi @DracoBlue, thanks a lot, this is looking good!

@kvz kvz merged commit 5556292 into kvz:master Aug 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DracoBlue DracoBlue deleted the unknown repository branch Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment