Invalid example of middleware toggle usage

[josalmi]

The readme contains an example Middleware toggle usage here: https://github.com/kwhitley/apicache#use-with-middleware-toggle-for-fine-control

However, in reality toggle middleware is executed before request is passed to the next middleware (See: apicache.js#L282, therefore status code will always be 200 while executing the toggle middleware in both of the endpoint listed in example. Status codes include options should be used instead for caching 200 responses only.

The toggle middleware functionality might be working as intended in which case the example is wrong or this could be a bug and the example should be working.

[kwhitley]

I'll look into this @josalmi - if nothing else, this is definitely something to add to a future release (pre/post route passes for caching)... will try and see if I can work something in the existing [dated] architecture in the meantime...

[kitce]

I am having the same issue.

Will it be fixed in the next version?

[kwhitley]

I'm working on a fix now! Should be going out in 0.11.1 tonight/tomorrow

[kwhitley]

@josalmi @kitce @huhuime
Fixed in apicache v0.11.1 (releasing to NPM tonight)

Thanks for bringing it to our attention!