make sure i18n_routing doesn't override I18n.locale #21

Merged
merged 2 commits into from Sep 14, 2011

Conversation

Projects
None yet
2 participants
@fishman
Contributor

fishman commented Aug 26, 2011

No description provided.

@kwi

This comment has been minimized.

Show comment Hide comment
@kwi

kwi Aug 27, 2011

Owner

Hey, thanks for the pull request, what kinf of bug is this fixing exactly ?

Thanks!

Owner

kwi commented Aug 27, 2011

Hey, thanks for the pull request, what kinf of bug is this fixing exactly ?

Thanks!

@fishman

This comment has been minimized.

Show comment Hide comment
@fishman

fishman Aug 31, 2011

Contributor

when you do anything in a rake task for example that needs locales. the way i18n_routing generates routes, it will parse through all locales and subsequently set I18n.locale to the last locale. in my case the last locale is not the default locale, therefore the default locale of rake tasks is not what it should be.

Contributor

fishman commented Aug 31, 2011

when you do anything in a rake task for example that needs locales. the way i18n_routing generates routes, it will parse through all locales and subsequently set I18n.locale to the last locale. in my case the last locale is not the default locale, therefore the default locale of rake tasks is not what it should be.

kwi added a commit that referenced this pull request Sep 14, 2011

Merge pull request #21 from fishman/master
make sure i18n_routing doesn't override I18n.locale

@kwi kwi merged commit fd6fb4b into kwi:master Sep 14, 2011

@kwi

This comment has been minimized.

Show comment Hide comment
@kwi

kwi Sep 14, 2011

Owner

Thanks :) merged !

Owner

kwi commented Sep 14, 2011

Thanks :) merged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment