Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UkrainianCurrencyTransformer #29

Merged
merged 8 commits into from Jan 24, 2018

Conversation

Projects
None yet
2 participants
@andreybolonin
Copy link
Contributor

andreybolonin commented Dec 29, 2017

No description provided.

andreybolonin and others added some commits Dec 29, 2017

@kwn

This comment has been minimized.

Copy link
Owner

kwn commented Jan 22, 2018

Hi @andreybolonin ! Thank you for your contribution. So the reason why I didn't add Ukrainian before was that because there were no tests. Could you please add a couple of tests for the currency converter? It's just to make sure that this converter actually works.

@andreybolonin

This comment has been minimized.

Copy link
Contributor Author

andreybolonin commented Jan 24, 2018

@kwn tests passed

@kwn

This comment has been minimized.

Copy link
Owner

kwn commented Jan 24, 2018

@andreybolonin

Perfect! Thank you so much. I'm merging it and I'm going to create a new release fairly soon.

@kwn kwn merged commit a6d0d9c into kwn:master Jan 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.